Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NXDRIVE-2942: Improve folder selection on Direct Transfer screen #5139

Open
wants to merge 13 commits into
base: master
Choose a base branch
from
Open

NXDRIVE-2942: Improve folder selection on Direct Transfer screen #5139

wants to merge 13 commits into from

Conversation

gitofanindya
Copy link
Collaborator

NXDRIVE-2942: Improve folder selection on Direct Transfer screen

@sourcery-ai Sourcery AI
Copy link
Contributor

sourcery-ai bot commented Aug 6, 2024 •
edited
Loading

🧙 Sourcery has finished reviewing your pull request!

Tips
  • Trigger a new Sourcery review by commenting @sourcery-ai review on the pull request.
  • Continue your discussion with Sourcery by replying directly to review comments.
  • You can change your review settings at any time by accessing your dashboard:
    • Enable or disable the Sourcery-generated pull request summary or reviewer's guide;
    • Change the review language;
  • You can always contact us if you have any questions or feedback.

sourcery-ai[bot]
sourcery-ai bot reviewed Aug 6, 2024
View reviewed changes
Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We've reviewed this pull request using the Sourcery rules engine. If you would also like our AI-powered code review then let us know.

@codecov Codecov
Copy link

codecov bot commented Aug 6, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 21.05263% with 15 lines in your changes missing coverage. Please review.

Project coverage is 52.22%. Comparing base (74fc14e) to head (2a295fe).
Report is 22 commits behind head on master.

Files Patch % Lines
nxdrive/gui/folders_model.py 16.66% 15 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #5139      +/-   ##
==========================================
+ Coverage   49.24%   52.22%   +2.97%     
==========================================
  Files          94       95       +1     
  Lines       15699    16069     +370     
==========================================
+ Hits         7731     8392     +661     
+ Misses       7968     7677     -291
Flag Coverage Δ
functional 42.96% <21.05%> (+4.88%) ⬆️
integration 2.01% <0.00%> (-0.05%) ⬇️
unit 40.55% <15.78%> (+2.98%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gitofanindya gitofanindya force-pushed the wip-NXDRIVE-2942-Improve-folder-selection-on-direct-transfer-screen branch from d3a05a1 to 8d99fb8 Compare August 14, 2024 12:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sourcery-ai sourcery-ai[bot] sourcery-ai[bot] left review comments

@mr-shekhar mr-shekhar Awaiting requested review from mr-shekhar

@poojadaine poojadaine Awaiting requested review from poojadaine

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@gitofanindya